[HUDI-5283] Replace deprecated method Schema.parse With Schema.Parser.#7308
Merged
danny0405 merged 1 commit intoapache:masterfrom Nov 28, 2022
Merged
[HUDI-5283] Replace deprecated method Schema.parse With Schema.Parser.#7308danny0405 merged 1 commit intoapache:masterfrom
danny0405 merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@yihua Can you help review this pr? Thank you very much! Can you allow me to assign jira？ |
danny0405
added
priority:medium
Collaborator
Contributor
|
The failed test case: |
codope
reviewed
Nov 28, 2022
| if (writeConfig.getSchema() != null) { | ||
| // Use schema specified by user if set | ||
| Schema userSchema = Schema.parse(writeConfig.getSchema()); | ||
| Schema userSchema = new Schema.Parser().parse(writeConfig.getSchema()); |
Member
There was a problem hiding this comment.
I see one more usage in AvroFileDeltaInputWriter in hudi-integ-test. Though it's not critical but would be good to fix there as well.
Contributor
There was a problem hiding this comment.
Oops, didn't see it, @slfan1989 , can you fire another minor PR to track this.
Contributor
Author
There was a problem hiding this comment.
Thanks for helping to review the code @codope @danny0405 , I will continue to follow up.
Contributor
Author
There was a problem hiding this comment.
@codope I will modify it to the mock method.
satishkotha
pushed a commit
to satishkotha/incubator-hudi
that referenced
this pull request
Dec 12, 2022
…apache#7308) Co-authored-by: slfan1989 <louj1988@@>
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
…apache#7308) Co-authored-by: slfan1989 <louj1988@@>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
JIRA: HUDI-5283. Replace deprecated method Schema.parse With Schema.Parser.
When reading the code, I found that
HoodieBootstrapSchemaProvider#getBootstrapSchemauses the deprecated methodSchema.parse, which can be replaced bySchema.Parser().parse(),At the same time, I searched at the moudle level, only to find that this place uses an deprecated method.
Impact
none.
Risk level (write none, low medium or high below)
none.
Documentation Update
none.
Contributor's checklist